Chapter 5. Submitting Patches

Table of Contents
5.1. Patch Format
5.2. Some notes about style
5.3. Quality Assurance

Written by Albert den Haan

5.1. Patch Format

Your patch should include:

cvs diff -u works great for the common case where a file is edited. However, if you add or remove a file cvs diff will not report that correctly so make sure you explicitly take care of this rare case.

For additions: mention that you have some new files and include them as either separate attachments or by appending the diff -u /dev/null /my/new/file output of them to any cvs diff -u output you may have. Alternatively, use diff -Nu olddir/ newdir/ in case of multiple new files to add.

For removals, list the files.

Since wine is constantly changing due to development it is strongly recomended that you use cvs for patches, if you cannot use cvs for some reason, you can submit patches against the latest tarball. To do this make a copy of the files that you will be modifying and diff -u against the old file. I.E.

diff -u file.old file.c > file.txt